Skip to content

Fix/1967 nutrition removal unclear #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seyfeb merged 4 commits into from
Dec 13, 2023
Merged

Fix/1967 nutrition removal unclear #1978

seyfeb merged 4 commits into from
Dec 13, 2023

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Dec 13, 2023

Topic and Scope

Adds button, removes nutrition option for deleting nutrition items.

Closes 1967

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@seyfeb
fix: Replace unclear option in EditMultiselectInputGroup (used for …
5b96d97 
…nutrition) for deleting an item with designated button.

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb
fix(Accessibility): Make aria-label strings translatable which were…
a15d917 
… forgotten

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb
chore: Update CHANGELOG
299b751 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb
Fix code style
5c32b84 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb
Copy link
Collaborator Author

seyfeb commented Dec 13, 2023

/approve

nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

github-actions bot commented Dec 13, 2023

Test Results

552 tests   552 ✔️  19s ⏱️
143 suites      0 💤
    3 files        0 ❌

Results for commit 5c32b84.

@seyfeb seyfeb merged commit ce45d3c into master Dec 13, 2023
@seyfeb seyfeb deleted the fix/1967-nutrition-removal-unclear branch December 13, 2023 10:10
@seyfeb seyfeb mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seyfeb @nextcloud-cookbook-bot